Repository navigation
Remove network external member endpoints - #197
Merged
Merged
Conversation
This was referenced Sep 30, 2026
Gerrit91
approved these changes
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
With #174 and several consecutive PRs we introduced endpoints which allow connecting external hosts to our networks. External means that the hosts are not known to the api, i.e. they are not registered machines. This approach was meant to replace a metal-core PR that meant to implement the same functionality via statically configurable port VRFs.
Implementing the memberships via API touches upon MEP-17, where we plan to make switch management more API-driven rather than deployment-driven. However, it turns out that moving only partially towards MEP-17 while still managing part of the switches via deployment creates a complicated mixture. While we do plan to implement MEP-17 in the near future, the functionality that the PRs mentioned above introduced is needed quickly and it should not be the entry point for implementing MEP-17. Therefore, I re-opened the metal-core PR and reverted the previous api PRs.
Used AI-Tools ✨