Skip to content

Run Windows and macOS tests weekly - #147

Open
rcosta358 wants to merge 21 commits into
codex/issue-133-webview-lifecyclefrom
codex/issue-134-platform-tests
Open

rcosta358 wants to merge 21 commits into
codex/issue-133-webview-lifecyclefrom
codex/issue-134-platform-tests

Conversation

@rcosta358

@rcosta358 rcosta358 commented Oct 2, 2026 •

Copy link
Copy Markdown
Collaborator

Description

Closes #134.

Add weekly and manual Windows/macOS runs for client and server unit tests plus VS Code stable integration tests, with logs uploaded on failure.

Related Issues

Stacked on #146, whose dependency chain (#145, #144, #143, #138, #137) leads to main. This branch also incorporates #139 (publish the checked VSIX), #141 (server unit tests), and #142 (client unit tests), which must land before this PR. The platform schedule becomes active when the stack reaches the default branch.

Validation: 32 client unit tests, 24 server unit tests, TypeScript checks, lint, both VS Code stable integration fixture suites, and local extension packaging/installation passed on the updated branch. Earlier Windows/macOS execution (before these dependency merges): https://github.com/liquid-java/vscode-liquidjava/actions/runs/37034618182

🤖 Generated with Codex

@rcosta358 rcosta358 added the testing Testing related label Oct 2, 2026

@CatarinaGamboa CatarinaGamboa left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Base branch: this PR targets codex/phase-4-test-base, which has no PR to main and doesn't contain #139 (git merge-base --is-ancestor on #139's branch and phase-4: not an ancestor). Merging here won't get the weekly workflow onto main, and the schedule only runs from the default branch. Once the stack lands, this needs its base changed to main (or to the last PR in the stack), and it should be rebased onto a base that includes #139.

Reviewed with Claude Code (reviewer + adversarial agents per PR, findings checked against the code before posting).

rcosta358 and others added 6 commits October 4, 2026 15:28
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>

# Conflicts:
#	.github/workflows/test.yml
Co-authored-by: Codex <noreply@openai.com>

# Conflicts:
#	.github/workflows/test.yml
Co-authored-by: Codex <noreply@openai.com>
@rcosta358
rcosta358 changed the base branch from codex/phase-4-test-base to codex/issue-133-webview-lifecycle October 4, 2026 14:39
@rcosta358

Copy link
Copy Markdown
Collaborator Author

Retargeted this PR onto #146, which leads through the stack to main, and merged #139 into the branch (939e85e). The description now lists the additional unit-test dependencies and notes that the schedule activates once it reaches the default branch. Client/server tests, stable integration, and full extension installation passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testing Testing related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants