Repository navigation
Fix Refinement Declaration Positions - #331
Merged
rcosta358 merged 2 commits intoOct 6, 2026
Merged
Conversation
rcosta358
added
bug
rcosta358
changed the title
rcosta358
added this pull request to stack #332
October 5, 2026 14:10
CatarinaGamboa
approved these changes
Oct 6, 2026
CatarinaGamboa
left a comment
CatarinaGamboa
left a comment
Collaborator
There was a problem hiding this comment.
testing is a bit tricky, left a message
| } | ||
| } | ||
|
|
||
| private static void assertPredicatePosition(SourcePosition position, Path file, String source, String predicate) |
Collaborator
There was a problem hiding this comment.
we should be careful with these string checks cause we might decide change the erro message and then we have to change all these tests. Do you think theres a way to make it less dependendt?
rcosta358
force-pushed
the
codex/refinement-declaration-position
branch
3 times, most recently
from
October 6, 2026 15:12
cd8510a to
ce7a2b7
Compare
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
rcosta358
force-pushed
the
codex/refinement-declaration-position
branch
from
October 6, 2026 15:18
ce7a2b7 to
a9e7e28
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Highlight the predicate in “Refinement declared here” diagnostics by reading its annotation position directly, removing the dependency on parsing order.
Example
Before
After
Validation: 206 tests passed, including declaration-position regression tests.
Related Issues
Stacked on #330. Merge it first, then retarget to
main.🤖 Generated with Codex