Update in-repo api dependency when releasing the api - #310
Merged
Merged
Conversation
./release.sh api only bumped liquidjava-api/pom.xml, leaving the verifier and example on the previous api version until someone edited them by hand. The release commit now bumps both dependents too. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
rcosta358
approved these changes
Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
./release.sh apionly bumped the version inliquidjava-api/pom.xml. The verifier and example kept depending on the previous api version until someone updated them by hand (as happened in the 0.0.7 release). The api release commit now also bumps theliquidjava-apidependency inliquidjava-verifier/pom.xmlandliquidjava-example/pom.xml.The verifier release path is unchanged.
This replaces #309: this repo doesn't need Dependabot for its own api, since the release script now keeps the modules in sync.
Example
Related Issue
#309
Type of change
Checklist
liquidjava-example/src/main/java/testSuite/(Correct*/Error*) (n/a, script change)mvn testpasses locallyTesting
Ran the patched script in a throwaway clone with a local bare repo as
origin:./release.sh api 0.0.8: one commit bumps all three poms, tagsapi-v0.0.8, pushes.mvn clean installwith api 0.0.8 not published anywhere: builds, resolving the api from the reactor (as CI does)../release.sh verifier 0.0.36: unchanged, only the verifier pom is committed; 338 tests pass.🤖 Generated with Claude Code