Repository navigation
chore(effect): upgrade to stable effect 4.0.0 - #80
Merged
Merged
Conversation
- Bump catalog from 4.0.0-beta.107 to 4.0.0 - Move imports off `effect/unstable/*`: `effect/http`, `effect/encoding/Sse` - Attach schema helpers with Object.defineProperties; `make`/`is` are now setter-less prototype getters, so Object.assign throws at load Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> HumanLayer-Session: https://app.dev.codelayer.gg/sessions/01a103b0-a7fb-7001-92c0-90b76151d9e4
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Docs Agent ReviewAgent finished with reason: error To apply these recommendations, comment: |
Replace the defineProperties shim with plain helpers that don't collide
with Effect 4's built-in `make`:
- ToolCallPart: use Schema.tag('tool-call') and Effect's own make
- SystemPart.make -> SystemPart.text
- ToolResultValue.make -> ToolResultValue.from
- ToolResultPart.make -> ToolResultPart.from
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
HumanLayer-Session: https://app.dev.codelayer.gg/sessions/01a103b0-a7fb-7001-92c0-90b76151d9e4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moves from
effect@4.0.0-beta.107to stableeffect@4.0.0.Catalog bump in root
package.json; lockfile updated. Stable 4.0.0 has no runtime deps, somsgpackrandkubernetes-typesdrop out.Import paths: stable promoted the
unstablemodules we use.effect/unstable/http→effect/http,effect/unstable/encoding/Sse→effect/encoding/Sse(all inopencode-llm-vendor).Schema
makecollisions: in 4.0.0, every schema has a built-inmake(a getter with no setter), soObject.assign(schema, { make })threw at module load. Instead of overriding it, the vendored helpers no longer use that name:ToolCallPart:typeis nowSchema.tag('tool-call'), so Effect's ownmakefills it in. The call site is unchanged, andmakenow checks its input.SystemPart.make(text)→SystemPart.text(text)ToolResultValue.make(value, type)→ToolResultValue.from(value, type)ToolResultPart.make(input)→ToolResultPart.from(input)Upstream opencode is still on beta.83, so this part diverges from upstream.
Testing
bun checkpasses: typecheck, biome, tests (1276 pass, 0 fail).🤖 Generated with Claude Code