Fix storefront wrapper theme inheritance - #1492
Merged
wcole1-godaddy merged 1 commit intoOct 2, 2026
Merged
wcole1-godaddy merged 1 commit into
wcole1-godaddy merged 1 commit into
Conversation
🦋 Changeset detectedLatest commit: e876027 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
wcole1-godaddy
approved these changes
Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Storefront wrappers force white backgrounds and dark text on dark websites. Default
.commerce-storefrontto a transparent background and inherited text color, while preserving explicit--commerce-surfaceand--commerce-textoverrides.Update the compiled CSS assertions and document the new defaults. Controls and the portalled cart drawer retain their existing palette and can be customized through the theme variables.
Changeset
@godaddy/gd-commerce-storefront.Test Plan
pnpm --filter @godaddy/gd-commerce-storefront build— passed.pnpm --filter @godaddy/gd-commerce-storefront test— all 28 tests passed, including compiled CSS and Tailwind v3 compatibility checks.pnpm --filter @godaddy/gd-commerce-storefront lint— passed.git diff --check— passed.