Repository navigation
Refetch shipping on coupon application #1441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
pbennett1-godaddy
wants to merge
38
commits into
main
Choose a base branch
from
refetch-shipping-on-coupon-application
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+2,980
−688
Open
Changes from all commits
Commits
Show all changes
38 commits
Select commit
Hold shift + click to select a range
7d6ddec
fix: adjust billing collection logic
pbennett1-godaddy 2caa59f
add changeset
pbennett1-godaddy 4db2dc6
feat(react): add billing policy resolver
pbennett1-godaddy a5c1135
test(react): lock billing policy contracts
pbennett1-godaddy 188cf87
feat(react): migrate billing renderers to policy
pbennett1-godaddy 933221c
feat(react): refactor checkout trigger field filtering
pbennett1-godaddy 33207a6
feat(react): add billing policy transition controller
pbennett1-godaddy 111fe18
feat(react): add policy-aware checkout validation adapter
pbennett1-godaddy 8f77713
feat(react): finalize billing policy validation
pbennett1-godaddy 48012b4
biome fix
pbennett1-godaddy 89ab144
do not prevent tax call on zero order after discount
pbennett1-godaddy 222590a
update billing policy for shipping scenarios
pbennett1-godaddy 29664cb
add tax fix for discounts on purchase and digital orders
pbennett1-godaddy bfb13f8
update billing policy for shipping flags
pbennett1-godaddy 6a7e6c7
adjust changeset
pbennett1-godaddy 3af3471
use consts for billing mode and locations
pbennett1-godaddy b10a141
add additional billing tests and do not treat null total as free
pbennett1-godaddy c7c5885
add billing address to stripe payments
pbennett1-godaddy d845174
adjust sku and order hydration and refetches
pbennett1-godaddy 4057110
always use flushed updated order on checkout
pbennett1-godaddy f46f8f0
checkout payment flush test for e2e with latest order
pbennett1-godaddy 29c4f33
hydrate contact email from shipping or billing data
pbennett1-godaddy 6da79fb
refetch shipping methods and recalc taxes on coupon application
pbennett1-godaddy b284c92
add tests and changeset
pbennett1-godaddy 12d9f5b
add reconcileAfterDiscount hook
pbennett1-godaddy a6da3cc
fix duplicate shipping reconciliation when shipping rates fails or re…
pbennett1-godaddy b64fff2
bail on shipping and methods if API failure
pbennett1-godaddy 58857d0
keeps the previous shipping selection when discount reconciliation fails
pbennett1-godaddy 52dcd66
Merge main into refetch-shipping-on-coupon-application
pbennett1-godaddy 8a2e568
show retry on shipping method fetch failure
pbennett1-godaddy 2120f6a
Merge branch 'main' into refetch-shipping-on-coupon-application
pbennett1-godaddy d1fe607
fix shiping application failed fallback scenarios
pbennett1-godaddy 7f34996
consolidate changesets
pbennett1-godaddy 4d8fd7e
Merge branch 'main' into refetch-shipping-on-coupon-application
pbennett1-godaddy 92a0191
Address PR review feedback on shipping selection and express coupons
pbennett1-godaddy 5668370
Fix automatic shipping selection loop and drop wallet coupon rate ref…
pbennett1-godaddy 66ebce6
Reuse shared discount-code helper in DiscountStandalone and trim chan…
pbennett1-godaddy 987d294
Merge branch 'main' into refetch-shipping-on-coupon-application
pbennett1-godaddy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| --- | ||
| "@godaddy/react": patch | ||
| "@godaddy/localizations": patch | ||
| --- | ||
|
|
||
| Keep shipping rates, discounts, and taxes in sync when coupons change, and show a retry action when shipping rates fail to load. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: this MercadoPago string change (du → Sie) is unrelated to the PR. Fine to keep, but please mention it in the changeset or split it out.