feat(schema): COMCORE-5156 add collection target to payment action schema - #293
Open
sgopalan-godaddy wants to merge 1 commit into
Open
sgopalan-godaddy wants to merge 1 commit into
sgopalan-godaddy wants to merge 1 commit into
Conversation
sgopalan-godaddy
requested review from
axburgess-godaddy,
jpage-godaddy,
jpearlman-godaddy,
mguerrero3-godaddy,
qcai-godaddy,
rts1-godaddy,
smukherjee-godaddy and
wcole1-godaddy
as code owners
September 25, 2026 16:25
sgopalan-godaddy
changed the title
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Anchor the schema pattern so invalid prefixed or suffixed IDs are rejected.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
Open (1)
What changed in this PR
Adds optional collectionEntityTargetId support to the commerce payment action schema for terminal-directed payments.
Changes:
- Adds a reusable ID definition and optional collection target property.
- Adds schema tests for optionality and accepted ID formats.
| File | Description |
|---|---|
rust/src/platform/actions/mod.rs |
Tests the new schema field and ID formats. |
rust/schemas/actions/commerce-payment-process.json |
Defines collectionEntityTargetId and its ID schema. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| "$schema": "https://json-schema.org/draft/2020-12/schema", | ||
| "description": "Custom ID format that can take a URN or a UUID", | ||
| "example": "urn:tid:oak:410dee2e-abbf-3f59-b640-fc3aca175344", | ||
| "pattern": "([0-9a-f]{8}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{12})|(urn:[a-z]{1,3}:[a-z]{1,3}:[0-9a-f]{8}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{12})", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://godaddy-corp.atlassian.net/browse/COMCORE-5156
collectionEntityTargetIdwill be passed to GPA to drive a specific outcome based on that. When a caller supplies collectionEntityTargetId, the GPA creates a Commerce Payment Request, and Payment Requests uses Payment Bridge to present the payment on the selected Poynt terminal.