Skip to content

Revert community submission intake and outcome reporting changes for additional testing - #4831

Merged
KSchlobohm merged 1 commit into
github:mainfrom
KSchlobohm:kschlobohm-oct-3-revert-intake-workflows
Oct 3, 2026
Merged

KSchlobohm merged 1 commit into
github:mainfrom
KSchlobohm:kschlobohm-oct-3-revert-intake-workflows

Conversation

@KSchlobohm

@KSchlobohm KSchlobohm commented Oct 3, 2026 •

Copy link
Copy Markdown
Contributor

Description

Create space for additional hosted testing before asking upstream to carry the community-submission intake and outcome-reporting changes.

This reverts #4829 and its squash merge commit de0cbd762e2d0b30f90d3ffcbe2ee9d7167f4eda as an exact nine-file inverse. The contributor wants more confidence in hosted behavior before proceeding with or reintroducing the change, especially around comment ownership and tone, publication-state reconciliation, failure paths, and the long-term test strategy.

This is a temporary confidence-building step, not a finding that #4829 is defective or a permanent rejection of its goals. The tradeoff is explicit: extension, preset, and bundle submissions again require the prior exact title prefixes, and title mismatches again stop without an explanatory outcome comment. The shared all-path outcome and fallback reporting is also removed until the additional testing and design work is ready.

The revert intentionally removes the shared prompt, its feature-specific tests, and its documentation because those surfaces exist only for the reverted behavior. Their absence is expected; retained baseline workflow wiring remains covered by the existing workflow tests.

This does not revert or modify #4830, including tests/specify_cli/workflows/test_catalog_versions.py. It also does not close or otherwise mutate the issues that motivated #4829. No separate fork experimentation is included or required by this upstream revert.

Testing

  • Tested locally with uv run specify --help
  • Ran existing tests with uv sync && uv run pytest
  • Tested with a sample project (if applicable)

Exact local validation on Windows, using this worktree and Python 3.11.5:

Command / check Result
uv sync --extra test Passed; created this worktree's missing .venv and installed test dependencies.
gh aw version Reported v0.88.7.
gh aw compile add-community-extension add-community-preset add-community-bundle --no-check-update Passed: 3 workflows compiled, 0 warnings. The generated lock files matched the revert; only the compiler's duplicate .gitattributes line was removed.
.venv\Scripts\python.exe -m pytest tests\test_github_workflows.py -q Passed: 104 tests, 16 skipped.
npx --yes markdownlint-cli2 "docs/guides/agentic-sdlc.md" Passed with 0 issues.
git diff --check and git diff --cached --check Passed.
git write-tree compared with de0cbd762e2d0b30f90d3ffcbe2ee9d7167f4eda^1^{tree} Exact match: b1be4e54264194697401b55ec02ad4e2b99c00ff.
PR patch/file API comparison The staged file list matches all nine files from #4829, and the #4829 patch reapplies cleanly to the reverted index with git apply --cached --check.
Search for catalog-submission.md, test_submission_outcomes, and submission_outcomes references No remaining references.

The merged #4829 checks and the current main checks were green, including the cross-platform Python matrix, markdownlint, CodeQL, dependency audit, and related repository checks. This revert is not claiming those checks failed; it creates room for additional hosted behavior testing beyond them.

No hosted workflow runs were created for this preparation. The full Python suite, CLI help, and sample-project tests were not run because this is the exact inverse of the workflow feature and its feature-only tests, with targeted baseline workflow wiring coverage retained. Hosted failure injection and comment/publication reconciliation scenarios remain the validation work desired before reintroduction.

AI Disclosure

  • I did not use AI assistance for this contribution
  • I did use AI assistance (fill in the disclosure below)

AI disclosure: The contributor directed this revert. GitHub Copilot App, powered by GPT-5.6 Sol, applied the exact revert, compared it with the merged PR patch and file API, regenerated and checked workflow locks, ran local validation, and drafted this pull request body in autonomous/autopilot mode. Reasoning effort was runtime-selected and not explicitly overridden. Publication was explicitly approved by the contributor.

Create space for additional hosted validation before proceeding with or reintroducing the changes from github#4829.

Assisted-by: GitHub Copilot App (model: GPT-5.6 Sol Fast (Internal only), autonomous)

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings October 3, 2026 16:35
@KSchlobohm
KSchlobohm requested a review from mnriem as a code owner October 3, 2026 16:35

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The nine-file change consistently reverses #4829 while retaining baseline workflow coverage.

Review effort: Balanced
Findings: None

What changed in this PR

Reverts #4829 to restore the prior community-submission workflow behavior pending additional hosted testing.

Changes:

  • Restores exact title-prefix validation for extension, preset, and bundle submissions.
  • Removes shared outcome reporting, related documentation, and feature-specific tests.
  • Regenerates all three compiled workflow locks.
File Description
.github/​workflows/​add-community-extension.md Restores extension title gating.
.github/​workflows/​add-community-extension.lock.yml Reverts compiled extension workflow.
.github/​workflows/​add-community-preset.md Restores preset title gating.
.github/​workflows/​add-community-preset.lock.yml Reverts compiled preset workflow.
.github/​workflows/​add-community-bundle.md Restores bundle title gating.
.github/​workflows/​add-community-bundle.lock.yml Reverts compiled bundle workflow.
.github/​workflows/​shared/​catalog-submission.md Removes shared intake and reporting behavior.
tests/​test_submission_outcomes.py Removes tests specific to reverted behavior.
docs/​guides/​agentic-sdlc.md Removes documentation for reverted behavior.

💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@KSchlobohm
KSchlobohm merged commit ae5ade7 into github:main Oct 3, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants