Conversation
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The fix is in an unreferenced duplicate file, while runtime consumers and the test still use the unchanged common.ps1.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Adds PowerShell helper logic intended to reject unusable python3 executables, plus regression coverage.
Changes:
- Adds a duplicate PowerShell common-functions file.
- Adds a cross-platform interpreter-selection regression test.
| File | Description |
|---|---|
scripts/powershell/common-fi.ps1 |
Adds duplicated common helpers with updated Python detection. |
tests/test_common_ps1_python3_command.py |
Tests fallback from an unusable python3. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| if (Get-Command python3 -ErrorAction SilentlyContinue) { | ||
| $ver = & python3 --version 2>&1 | ||
| if ($ver -match 'Python 3') { | ||
| & python3 -c 'import yaml' *> $null | ||
| if ($LASTEXITCODE -eq 0) { return @('python3') } |
|
Thanks for taking the time to investigate this and add regression coverage. The underlying problem is valid: PowerShell should not select a I’m closing this PR because #4151 already addresses the same issue with broader coverage, including fallback to Thank you again for the contribution. Consolidating the work in the existing PR will help us avoid competing implementations and keep the review focused. |

Description
Testing
uv run specify --helpuv sync && uv run pytestAI Disclosure
AI disclosure: N/A