Conversation
hvitved
force-pushed
the
unified/param-ex
branch
from
October 1, 2026 19:22
facee75 to
4939136
Compare
hvitved
marked this pull request as ready for review
October 1, 2026 19:29
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Callable ownership and observer-backed Swift properties are modeled incorrectly.
Review effort: Balanced
Findings: 1
Open (3)
What changed in this PR
Introduces ParameterEx to unify source and synthesized parameters, including Swift receivers and memberwise initializer parameters.
Changes:
- Adds the
ParameterExabstraction and plugin hook. - Implements Swift parameter synthesis.
- Extends constructor tests and expected results.
| File | Description |
|---|---|
ParameterEx.qll |
Defines unified parameter entities. |
AstPlugin.qll |
Adds parameter-synthesis plugin API. |
AstPluginSwift.qll |
Implements Swift memberwise parameters. |
test.ql |
Adds parameter queries. |
test.expected |
Records generated expectations. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
hvitved
force-pushed
the
unified/param-ex
branch
from
October 1, 2026 19:48
4939136 to
3544f46
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces #22690 by instead building on top of #22721 and only synthesizing parameters.