Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
---
category: minorAnalysis
---
* The Workflow SDK directives `"use workflow"` and `"use step"` are now recognized as known directives, so the `js/unknown-directive` query no longer flags them.
26 changes: 26 additions & 0 deletions javascript/ql/lib/semmle/javascript/Stmt.qll
Original file line number Diff line number Diff line change
Expand Up @@ -490,6 +490,32 @@ module Directive {
class WorkletDirective extends KnownDirective {
WorkletDirective() { this.getDirectiveText() = "worklet" }
}

/**
* A Workflow SDK `use workflow` directive.
*
* Example:
*
* ```
* "use workflow";
* ```
*/
class UseWorkflowDirective extends KnownDirective {
UseWorkflowDirective() { this.getDirectiveText() = "use workflow" }
}

/**
* A Workflow SDK `use step` directive.
*
* Example:
*
* ```
* "use step";
* ```
*/
class UseStepDirective extends KnownDirective {
UseStepDirective() { this.getDirectiveText() = "use step" }
}
}

/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,4 +19,6 @@
| tst.js:27:3:27:14 | 'use cache'; | use cache |
| tst.js:28:3:28:22 | 'use cache: remote'; | use cache: remote |
| tst.js:29:3:29:23 | 'use ca ... ivate'; | use cache: private |
| tst.js:36:5:36:17 | 'use strict'; | use strict |
| tst.js:30:3:30:17 | 'use workflow'; | use workflow |
| tst.js:31:3:31:13 | 'use step'; | use step |
| tst.js:38:5:38:17 | 'use strict'; | use strict |
2 changes: 2 additions & 0 deletions javascript/ql/test/library-tests/Directives/tst.js
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,8 @@ function f() {
'use cache';
'use cache: remote';
'use cache: private';
'use workflow';
'use step';
;
'use strict'; // but this isn't a directive
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
| UnknownDirective.js:12:5:12:17 | "use struct;" | Unknown directive: 'use struct;'. |
| UnknownDirective.js:13:5:13:17 | "Use Strict"; | Unknown directive: 'Use Strict'. |
| UnknownDirective.js:14:5:14:14 | "use bar"; | Unknown directive: 'use bar'. |
| UnknownDirective.js:43:5:43:17 | "[0, 0, 0];"; | Unknown directive: '[0, 0, 0];'. |
| UnknownDirective.js:44:5:44:65 | "[0, 0, ... , 0];"; | Unknown directive: '[0, 0, 0, 0, 0, 0, 0 ... (truncated)'. |
| UnknownDirective.js:50:5:50:15 | ":nomunge"; | Unknown directive: ':nomunge'. |
| UnknownDirective.js:51:5:51:30 | "foo(), ... munge"; | Unknown directive: 'foo(), bar, baz:nomu ... (truncated)'. |
| UnknownDirective.js:45:5:45:17 | "[0, 0, 0];"; | Unknown directive: '[0, 0, 0];'. |
| UnknownDirective.js:46:5:46:65 | "[0, 0, ... , 0];"; | Unknown directive: '[0, 0, 0, 0, 0, 0, 0 ... (truncated)'. |
| UnknownDirective.js:52:5:52:15 | ":nomunge"; | Unknown directive: ':nomunge'. |
| UnknownDirective.js:53:5:53:30 | "foo(), ... munge"; | Unknown directive: 'foo(), bar, baz:nomu ... (truncated)'. |
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,8 @@ function good() {
"use cache";
"use cache: remote";
"use cache: private";
"use workflow";
"use step";
}

function data() {
Expand Down
Loading