Conversation
Contributor
|
1 of 6 tasks
📲 Install BuildsAndroid
|
3 of 9 tasks
Co-Authored-By: Claude <noreply@anthropic.com>
wedamija
force-pushed
the
danf/spring-checkin-scheduled-config
branch
from
October 5, 2026 22:54
ff1e1e2 to
5d745c7
Compare
wedamija
force-pushed
the
danf/quartz-cron-config
branch
from
October 5, 2026 22:54
d27bf6b to
44ad1c7
Compare
Co-Authored-By: Claude <noreply@anthropic.com>
…nfig' into danf/quartz-merge-tmp # Conflicts: # CHANGELOG.md
wedamija
marked this pull request as ready for review
October 5, 2026 23:38
wedamija
requested review from
0xadam-brown,
adinauer,
markushi,
romtsn and
runningcode
as code owners
October 5, 2026 23:38
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 045b6d8. Configure here.
Co-Authored-By: Claude <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Stacked on #6215 (Spring), which is stacked on #6217 (core
MonitorConfigUtils). Merge those first.📜 Description
SentryJobListenernow sends the job's schedule with the in-progress check-in, so Sentry creates or updates the monitor from code. ACronTriggeris sent as a crontab with the trigger's time zone; aSimpleTriggerthat repeats forever is sent as an interval.This is on by default. Set the
sentry-upsert-monitor-configjob or trigger data key (SentryJobListener.SENTRY_UPSERT_MONITOR_CONFIG_KEY) to"false"to turn it off for a job.Schedules that can't be represented exactly (triggers with a calendar, jobs with several triggers, simple triggers that don't repeat forever, cron syntax Sentry doesn't support) send no config rather than a wrong one.
💡 Motivation and Context
Check-ins for monitors that don't exist in Sentry are dropped, so users create each monitor by hand. The trigger already has the schedule.
Features are usually opt-in, but adding the listener is already an explicit opt-in to monitoring, so this is on by default. On upgrade, existing monitors get their schedule and time zone from the trigger; set the key to
"false"to keep managing them in Sentry.💚 How did you test it?
SentryJobListenerTest. The conversion is tested in #6217.📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps
Docs: getsentry/sentry-docs#19777