fix(release): wait for the tag on Composer's metadata endpoint, not the CDN-cached web API - #11
Merged
Merged
Conversation
…he CDN-cached web API The publication job read packagist.org/packages/fireflyframework/larafly.json, which the CDN serves with s-maxage=43200. After v26.09.11 was indexed, Composer installed it from repo.packagist.org/p2 within a minute, but the job saw the twelve-hour-old document for its whole five-minute window and failed twice. It now reads the p2 metadata Composer uses, for up to ten minutes, and ReleaseWorkflowTest pins the endpoint.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The release workflow's publication job waited on
https://packagist.org/packages/fireflyframework/larafly.json, which the CDN serves withcache-control: public, s-maxage=43200. Afterv26.09.11was indexed, Composer installed it fromrepo.packagist.org/p2within a minute, but the job kept receiving the twelve-hour-old document for its whole five-minute window and failed on both attempts (run 36814736802).https://repo.packagist.org/p2/fireflyframework/larafly.json(the metadata Composer uses, refreshed when Packagist indexes a tag) and allows ten minutes.ReleaseWorkflowTestpins the endpoint;docs/publishing.mdexplains why and how earlier tags recover (a rerun after the CDN cache expires).actionlintis clean).Verification
ReleaseWorkflowTestand the documentation guards pass;actionlintis clean.v26.09.11at8bbad67.