Conversation
require "benchmark/ips"
def fast
end
def slow
end
Benchmark.ips do |x|
x.report("fast code description") { fast }
x.report("slow code description") { slow }
x.compare!
end
mateusdeap
left a comment
There was a problem hiding this comment.
@dukaev I don't know if you're already on this, but I believe that if you just add Ashwini's suggestions to your PR, in the issue this solves, we can merge it.
Thanks for the good work!
|
If not, that's fine. Just let me know and I can take it over. |
|
@mateusdeap great. In a few days I will do this |
|
Thanks @dukaev, and sorry this sat for so long. You spotted this in 2019: the fast code should come first so the template is easy to read at a glance. It has now landed on fast-ruby/.github/scripts/lint-benchmarks.rb Lines 1 to 12 in 86836b0 All 21 files you touched now follow that order, so I'm closing this one as superseded. Thanks for pushing on it early! |
#169