Conversation
stsdc
marked this pull request as ready for review
September 26, 2026 15:06
Member
|
I'm a fan. Seems more easily parsable at a glance too |
danirabbit
requested changes
Sep 26, 2026
| construct { | ||
| var icon = new Gtk.Image.from_icon_name (icon_name) { | ||
| margin_start = 6, | ||
| margin_end = 2, |
Member
There was a problem hiding this comment.
Don't love to have hardcoded margins. If we can solve the spacing with Granite.Box that would be best, otherwise we should use CSS so that the spacing scales with text size
| Object ( | ||
| orientation: Gtk.Orientation.HORIZONTAL, | ||
| icon_name: icon_name, | ||
| visible: false |
Member
There was a problem hiding this comment.
Can we put these in a revealer instead so we get nice animations?
|
|
||
| label.label = Utils.Strings.format_network_speed (bandwidth); | ||
| label.width_chars = 9; | ||
| label.label = "<span font-features='tnum'>%s</span>".printf (Utils.Strings.format_network_speed (bandwidth)); |
Member
There was a problem hiding this comment.
We don't need to use markup there's a CSS feature for this: Granite.CssClass.NUMERIC
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Grouping allows to save some space by using a single icon for all metrics of a device.
NEW:
OLD: