Skip to content

fix: order the Oxc plugin below the g-plane plugins - #85

Merged
dsherret merged 2 commits into
mainfrom
fix_oxc_never_preselect
Oct 3, 2026
Merged

dsherret merged 2 commits into
mainfrom
fix_oxc_never_preselect

Conversation

@dsherret

@dsherret dsherret commented Oct 3, 2026 •

Copy link
Copy Markdown
Member

dprint init pre-selects the first plugin in info.json order that matches a file type nothing earlier has claimed. Since #83 gave the Oxc plugin css, scss, less, graphql, gql, yaml and yml, and its entry sat above g-plane/malva, g-plane/pretty_yaml and g-plane/pretty_graphql, Oxc was what got pre-selected for a project with stylesheets or yaml files instead of those plugins.

This moves the Oxc entry below the g-plane plugins so they claim those file types first. Oxc is still pre-selected when it's the first plugin to match something (ex. .json5).

Related: dprint/dprint#1300 fixes the CLI not recognizing the g-plane plugins as already being in a config file, which is how this surfaced.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Oct 3, 2026 •

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
🔵 In progress
View logs
dprint-plugins 4d1dd74 Oct 03 2026, 10:23 PM

@dsherret dsherret changed the title fix: don't pre-select the Oxc plugin on dprint init fix: order the Oxc plugin below the g-plane plugins Oct 3, 2026
@dsherret

dsherret commented Oct 3, 2026 •

Copy link
Copy Markdown
Member Author

lol, this is completely wrong

Ok, it was and now it's fixed

@dsherret dsherret closed this Oct 3, 2026
@dsherret dsherret reopened this Oct 3, 2026
@dsherret
dsherret added this pull request to the merge queue Oct 3, 2026
Merged via the queue into main with commit 128183d Oct 3, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant