Skip to content

Remove dead code left after the security fixes #446

Description

@HMarzban

Summary

The security fixes left two pieces of dead code. Removing them stops a future change from reviving a closed path by accident.

Where

Fix plan

  1. Delete createDirectMessageChannel.ts and its line in apps/webapp/src/api/rpc/index.ts.
  2. Delete the NEXT_PUBLIC_ELASTIC_APM_SECRET_TOKEN line. If NEXT_PUBLIC_ELASTIC_APM_SERVER_URL (:343) also has no reader, delete it too.

Acceptance criteria

  • grep -rn "createDirectMessageChannel\|ELASTIC_APM" apps packages returns nothing.
  • bun run --filter @docs.plus/webapp typecheck and lint pass.

Activity

  1. added theissue type on Oct 6, 2026
  2. HMarzban commented on Oct 9, 2026

    @HMarzban
    CollaboratorAuthor

    Fixed and live.

    • Commits: 73e5bd972
    • Deployed in bbdaae66c (production run 37976785981, green).
    • The dead Elastic APM keys are gone from .env.example. Still yours: the commented token in the gitignored Notes/server/server.env.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions