Skip to content

fix(next-plugin): isolate coordinator port file and explain unreachable coordinators - #726

Open
owjs3901 wants to merge 2 commits into
mainfrom
fix/coordinator-port-isolation
Open

owjs3901 wants to merge 2 commits into
mainfrom
fix/coordinator-port-isolation

Conversation

@owjs3901

@owjs3901 owjs3901 commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor

Concurrent next dev and next build in one distDir shared coordinator.port, deleting and overwriting each other's port.

  • Port file records the owner pid (port stays on line 1, so older readers still work)
  • A live foreign owner's file is never removed; this process uses coordinator..port instead
  • Missing/unreachable coordinator errors report port, owner pid and state, file path and recovery; the cached port is dropped on connection errors

bun test 138 pass, tsc and lint clean. The Windows file:///home/runner/...plugin.ts failure is not addressed: no such path is built in next-plugin source.

W40 main 반영 (2026-10-06)

  • 2026-10-06: main의 a935315c34b45aeda6dc156e29a5c76df51b76bd까지 병합했습니다 (병합 head: 0fdd9970b50ee3ce767f9ef31d65902c203b56cf).
  • 충돌 해결: packages/next-plugin/src/loader.ts는 feat(plugins): deterministic class and file numbering #743 참조처럼 연결 오류/포트 캐시 제거를 먼저 처리한 뒤 main 의존성 등록과 정상 콜백을 실행합니다. 전체 WASM 경로와 게시 버전을 유지했고 참조의 포트 테스트 린트 및 누락된 연결 오류 경로만 보완했습니다. 번호 확정/stateWriter는 가져오지 않았습니다.
  • 검증: CI37438155520 success; 네 작업과 codecov/patch 모두 통과, MERGEABLE/CLEAN. Ubuntu Rust100%(9812/9812), Bun5489 pass/0 fail 및100%, landing 두 모드130개씩 통과. 직렬 빌드/1.99clippy/전체 훅, 집중 테스트26개와 실제 HTTP 의존성 전달·연결 오류 진단·새 포트 캐시 복구가 통과했습니다. fix(next-plugin): isolate coordinator port file and explain unreachable coordinators #726→feat(plugins): deterministic class and file numbering #743 기본 merge-tree는 exit0(tree c5d6cfa3dc15e21f8c5f8432b955927bddf91f2a)이고 #743은 변경하지 않았습니다. TypeScript LSP 미설치로 진단은 불가했습니다.
  • 새로 생기는 오류: 이번 병합으로 추가되는 오류는 없습니다. 기존 PR의 동작 및 남는 한계는 유지합니다.

Resolve packages/next-plugin/src/loader.ts using the #743 integration callback: preserve connection diagnostics/cache eviction and main dependency transport/full WASM. Apply the known coordinator-port test lint repair and add its missing connection-error coverage as a distinct EOF regression so the existing #743 test merges independently; retain main published versions, without numbering/state-writer features.

Refs #686

Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent)

Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
@github-actions

github-actions Bot commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

Changepacks

@devup-ui/next-plugin@1.0.90 → 1.0.91 - packages/next-plugin/package.json

Patch

  • Isolate the coordinator port file per owning process when another live next dev/build holds it, record the owner pid, and report port, pid and recovery when the coordinator is missing or unreachable

@codecov

codecov Bot commented Oct 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

Files with missing lines Coverage Δ
packages/next-plugin/src/coordinator-port.ts 100.00% <100.00%> (ø)
packages/next-plugin/src/coordinator.ts 100.00% <100.00%> (ø)
packages/next-plugin/src/css-loader.ts 100.00% <100.00%> (ø)
packages/next-plugin/src/loader.ts 100.00% <100.00%> (ø)
packages/next-plugin/src/plugin.ts 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant