Build Linux binaries on Ubuntu 22.04 - #21
Merged
Merged
Conversation
Contributor
Author
|
Checked the linux-x64 artifact from this PR's CI run: dawn.node now needs at most glibc 2.34 and GLIBCXX_3.4.30, the same as 0.4.0 and down from glibc 2.38 and GLIBCXX_3.4.32 in 0.6.1. Both are within what Ubuntu 22.04 provides (glibc 2.35, GLIBCXX_3.4.30), and npm test passed on the 22.04 runners for both x64 and ARM64. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://issues.chromium.org/issues/567909981
Moves the Linux x64 and ARM64 builds back to Ubuntu 22.04 so the published
dawn.nodeloads on 22.04 again.Since 0.5.0 the Linux binaries are built on 24.04 and require newer system libraries than 22.04 provides:
dawn.nodeGLIBCXX_3.4.30GLIBCXX_3.4.32GLIBCXX_3.4.30The new requirements come from
__isoc23_strtoland related functions (glibc 2.38 headers) and two GCC 13 libstdc++ symbols. They're inherent to the 24.04 toolchain, so no build flag avoids them.The move to 24.04 (a3d7101) happened while fixing the Linux build after a Dawn update. The failure at the time,
Failed to find wayland-scanner, also hit the ARM64 job that was already on 24.04, and-DDAWN_USE_WAYLAND=OFFhas since fixed it. This restores the 22.04 build from #7. ARM64 moves toubuntu-22.04-armfor the same reason; it has required glibc 2.38 since it was added.