Skip to content

Fix #15080 FP uninitMemberVarNoCtor for const and reference members #8910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
autoantwort wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix #15080 FP uninitMemberVarNoCtor for const and reference members #8910

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ba74606
Fix #15080 FP uninitMemberVarNoCtor for const and reference members
autoantwort Sep 30, 2026
b8fbea9
Const/reference member of non-class type inhibits uninitMemberVarNoCt…
autoantwort Oct 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion lib/checkclass.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -347,6 +347,7 @@ void CheckClassImpl::constructors()
// Variables with default initializers
bool hasAnyDefaultInit = false;
bool hasAnySelfInit = false;
bool isDefaultConstructible = true;
const bool cpp14OrLater = mSettings.standards.cpp >= Standards::CPP14;
for (Usage& usage : usageList) {
const Variable& var = *usage.var;
Expand All @@ -355,11 +356,14 @@ void CheckClassImpl::constructors()
if (var.hasDefault()) {
usage.init = true;
hasAnyDefaultInit = true;
} else if (var.isReference() || (var.isConst() && !var.isClass())) {
// the default constructor is deleted, so all members are initialized by every instance
isDefaultConstructible = false;
} else if (cpp14OrLater && !hasAnySelfInit && isInitialized(usage, FunctionType::eConstructor)) {
hasAnySelfInit = true;
}
}
if (!hasAnyDefaultInit && !hasAnySelfInit)
if (!isDefaultConstructible || (!hasAnyDefaultInit && !hasAnySelfInit))
continue;

handleUnionMembers(usageList);
Expand All @@ -373,6 +377,10 @@ void CheckClassImpl::constructors()
if (var.typeScope() && var.typeScope()->numConstructors > 0)
continue;

// a const member of class type is default constructed or makes the class not default constructible
if (var.isConst())
continue;

if (diagVars.count(&var) == 0)
uninitVarError(var.nameToken(), false, FunctionType::eConstructor, var.scope()->className, var.name(), false, false, true);
}
Expand Down
36 changes: 36 additions & 0 deletions test/testconstructors.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -797,6 +797,42 @@ class TestConstructors : public TestFixture {
ASSERT_EQUALS("[test.cpp:4:9]: (warning) Member variable 'T::j' has no initializer. [uninitMemberVarNoCtor]\n"
"[test.cpp:8:9]: (warning) Member variable 'U::k' has no initializer. [uninitMemberVarNoCtor]\n",
errout_str());

check("struct S {\n" // #15080
" int a = 0;\n"
" const int b;\n"
" int k;\n"
"};\n");
ASSERT_EQUALS("", errout_str());

check("struct S {\n"
" int a = 0;\n"
" int& c;\n"
" int k;\n"
"};\n");
ASSERT_EQUALS("", errout_str());

check("struct S {\n"
" int a = 0;\n"
" const int* d;\n"
"};\n");
ASSERT_EQUALS("[test.cpp:3:16]: (warning) Member variable 'S::d' has no initializer. [uninitMemberVarNoCtor]\n", errout_str());

check("struct S {\n"
" std::string a;\n"
" const std::string s;\n"
" int k;\n"
"};\n");
ASSERT_EQUALS("[test.cpp:4:9]: (warning) Member variable 'S::k' has no initializer. [uninitMemberVarNoCtor]\n", errout_str());

@chrchr-github chrchr-github Oct 3, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason to warn here?


check("struct S {\n"
" const std::array<std::uint8_t, 2> a;\n"
" const std::vector<std::uint8_t>::const_iterator it;\n"
"};\n"
"S f(const std::vector<std::uint8_t>& v) {\n"
" return S{ {}, v.cbegin() };\n"
"}\n");
ASSERT_EQUALS("", errout_str());
}

// ticket #4290 "False Positive: style (noConstructor): The class 'foo' does not have a constructor."
Expand Down
Loading