Keep spec quantifier binders from capturing clause variables - #295
Merged
Merged
Conversation
A `forall`/`exists` binder in an annotation was printed to SMT-LIB under its Rust name, which shares a namespace with the generated clause variables `v0`, `v1`, .... A binder named e.g. `v1` therefore captured the clause variable `v1`, changing the meaning of the formula, and could make a precondition collapse to `false` so that a panicking body verified. Print quantified variables with a `q$` prefix, which neither Rust identifiers nor generated symbols contain. Fixes #294 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AK15mUhCmYuTaGGygSSA85
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AK15mUhCmYuTaGGygSSA85
This was referenced Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #294.
forall/existsbinders in annotations were printed to SMT-LIB under their Rust names. Those names share a namespace with the generated clause variablesv0,v1, …, so a binder named, say,v1captured the clause variablev1. In the reproducer from #294 this turns the callee's precondition intofalse, and a panicking program verifies assafe.This PR prints quantified variables with a
q$prefix, in both the binder list and the occurrences (chc/smtlib2.rs). Neither Rust identifiers nor any generated symbol contain$, and z3 and PCSat both accept it.The #294 reproducer is rejected with
Unsatafter this change. The existingcargo testsuite passes locally with z3 5.0.0 and the pinned PCSat wrapper.🤖 Generated with Claude Code
https://claude.ai/code/session_01AK15mUhCmYuTaGGygSSA85