chore: bump github.com/coder/coder/v2 from 2.26.5 to 2.29.19 - #524
Merged
Merged
Conversation
johnstcn
approved these changes
Oct 2, 2026
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
It selects a containerd version affected by reachable GO-2026-6444 and relies on an unmerged draft follow-up for remediation.
Review effort: Balanced
Findings: 1
Open (2)
What changed in this PR
Upgrades the Coder SDK to address reported vulnerabilities and adapts affected APIs.
Changes:
- Updates Coder and transitive dependencies.
- Migrates agent authentication to
WithFixedToken. - Replaces deprecated go-billy test filesystem options.
| File | Description |
|---|---|
go.mod |
Updates dependencies, Go version, and replacements. |
go.sum |
Refreshes dependency checksums. |
log/coder.go |
Adapts Coder agent authentication. |
git/git_test.go |
Uses WithBoundOS in SSH tests. |
integration/integration_test.go |
Updates integration-test filesystems. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| github.com/containerd/containerd/v2 v2.1.1 // indirect | ||
| github.com/containerd/cgroups/v3 v3.1.0 // indirect | ||
| github.com/containerd/containerd/api v1.10.0 // indirect | ||
| github.com/containerd/containerd/v2 v2.2.0 // indirect |
| github.com/vishvananda/netlink v1.3.1-0.20250303224720-0e7078ed04c8 | ||
| ) | ||
|
|
||
| replace github.com/vishvananda/netlink => github.com/vishvananda/netlink v1.2.1-beta.2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the Coder SDK to the oldest release that clears every
github.com/coder/coder/v2advisory reported by govulncheck. envbuilder only importscodersdk,codersdk/agentsdkandagent/protofor log forwarding. Most of these advisories are coderd server bugs, but govulncheck flags them because the module is linked.govulncheck (symbol-level, vs.
main): 75 reachable to 35. Fixes all 17 coder/coder advisories and 24 transitive ones (x/crypto, go-git, go-billy, containerd, grpc, otel, go-jose).Changes needed beyond
go get:replace tailscale.commoved to the coder/tailscale commit that coder v2.29.19 pins.replace github.com/vishvananda/netlink => v1.2.1-beta.2.tailscale/netlinkdoes not compile against netlink v1.3.x, which containerd 2.2 now requires. coder/coder pins the same version.log/coder.go:agentsdk.Newnow takes aSessionTokenSetup. Usesagentsdk.WithFixedToken(token).godirective goes to 1.25.10, inherited from coder/coder.Notes for review:
ok .../integration 39.5s).Part of a set of independent dependency PRs (#524 to #533). They all touch
go.mod/go.sum, so after the first merge the rest needgo mod tidyand a rebase.Generated by Coder Agents on behalf of @stirby.