Repository navigation
chore: load amazing_print only in development and test - #2972
Merged
Merged
Conversation
Amazing_print is only used by SemanticLogger colour-formatted text logs in development; production logs go through CanonicalJsonFormatter and never touch it. Keeping it in the default group made every production dyno load an unused gem.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
amazing_print was declared in the default Gemfile group, so
Bundler.requireloaded it on boot in every environment, including production dynos. Nothing in the app uses it there: production logs go throughCanonicalJsonFormatter, and the only consumer of the gem anywhere isSemanticLogger::Formatters::Color, which soft-requires it to pretty-print payload hashes in coloured text logs. That formatter is only relevant to development and test console output.group :development, :test, alongside the other dev-only gemsGemfile.lockchange — the lockfile does not record groupsReview notes