Skip to content

fix: Change audit logs permission for org manager (OD-757) - #2769

Merged
nfcodacy merged 1 commit into
masterfrom
organization-managers-cant-access-audit-logs-od-757
Sep 29, 2026
Merged

nfcodacy merged 1 commit into
masterfrom
organization-managers-cant-access-audit-logs-od-757

Conversation

@nfcodacy

Copy link
Copy Markdown
Contributor

No description provided.

@nfcodacy
nfcodacy requested a review from a team as a code owner September 28, 2026 15:57
@github-actions

Copy link
Copy Markdown
Contributor

Overall readability score: 54.15 (🟢 +0)

File Readability
roles-and-permissions-for-organizations.md 61.51 (🟢 +0)
View detailed metrics

🟢 - Shows an increase in readability
🔴 - Shows a decrease in readability

File Readability FRE GF ARI CLI DCRS
roles-and-permissions-for-organizations.md 61.51 31.07 8.52 12 12.98 6.21
  🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0

Averages:

  Readability FRE GF ARI CLI DCRS
Average 54.15 42.99 10.91 12.34 12.27 8
  🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0
View metric targets
Metric Range Ideal score
Flesch Reading Ease 100 (very easy read) to 0 (extremely difficult read) 60
Gunning Fog 6 (very easy read) to 17 (extremely difficult read) 8 or less
Auto. Read. Index 6 (very easy read) to 14 (extremely difficult read) 8 or less
Coleman Liau Index 6 (very easy read) to 17 (extremely difficult read) 8 or less
Dale-Chall Readability 4.9 (very easy read) to 9.9 (extremely difficult read) 6.9 or less

@codacy-production

Copy link
Copy Markdown
Contributor

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

AI Reviewer: first review requested successfully. AI can make mistakes. Always validate suggestions.

Run reviewer

TIP This summary will be updated as you push new changes.

@codacy-production codacy-production Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

The required authorization behavior is not verifiable from this documentation-only change: managers must be denied audit-log access while admins retain access. No implementation change or authorization tests demonstrate either criterion, so this should not be merged unless enforcement is updated or the PR clearly establishes that the behavior already exists. Codacy reports the PR as up to standards with no new issues.

About this PR

  • This documentation-only change does not demonstrate that organization managers are denied audit-log access and organization admins retain access. Add the corresponding authorization change and automated tests, or provide evidence that enforcement is already implemented.

Test suggestions

  • Verify organization manager audit-log access is denied.
  • Verify organization admin audit-log access is allowed.
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Verify organization manager audit-log access is denied.
2. Verify organization admin audit-log access is allowed.
Low confidence findings
  • Add a PR description with explicit acceptance criteria and scope for the audit-log permission change.

TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback

@github-actions
github-actions Bot temporarily deployed to Netlify September 28, 2026 15:59 Inactive
@nfcodacy
nfcodacy merged commit 4df2d00 into master Sep 29, 2026
5 checks passed
@nfcodacy
nfcodacy deleted the organization-managers-cant-access-audit-logs-od-757 branch September 29, 2026 08:51

This branch was previously deployed

1 inactive deployment
Netlify — 8f54e529 Deployed Sep 28, 2026 by github-actions[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants