Skip to content

italy_yaml: fix loading of OutputOnly tasks (and some drive-by cleanups) - #1723

Merged
prandla merged 3 commits into
cms-dev:mainfrom
prandla:fix-outputonly
Sep 24, 2026
Merged

prandla merged 3 commits into
cms-dev:mainfrom
prandla:fix-outputonly

Conversation

@prandla

@prandla prandla commented Sep 24, 2026

Copy link
Copy Markdown
Member
  • loading of OutputOnly tasks with italy_yaml was broken, because the part that set OutputOnly was overwritten by a later if statement.
  • Changed the "communication NAND interactive" check to also take outputonly into account, and made that check actually terminate the process instead of just continuing anyways.
  • I also did a small cleanup (replace logging.fatal with logging.critical, since the former's docstring says "Don't use this function, use critical() instead.") and I removed some python 2 compat code.

the part that set OutputOnly was overwritten by the later if statement.
i also added a check to make sure only one of the non-Batch types is
specified.
logging.fatal's docstring says "Don't use this function, use critical()
instead."
@codecov

codecov Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 56.72%. Comparing base (06caa18) to head (9907de1).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
cmscontrib/loaders/italy_yaml.py 0.00% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1723      +/-   ##
==========================================
- Coverage   56.72%   56.72%   -0.01%     
==========================================
  Files         344      344              
  Lines       28310    28308       -2     
==========================================
- Hits        16059    16057       -2     
  Misses      12251    12251              
Flag Coverage Δ
functionaltests 0.00% <0.00%> (ø)
unittests 56.72% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@prandla
prandla merged commit 29b33e6 into cms-dev:main Sep 24, 2026
3 of 4 checks passed
@prandla
prandla deleted the fix-outputonly branch September 24, 2026 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants