italy_yaml: fix loading of OutputOnly tasks (and some drive-by cleanups) - #1723
Merged
Merged
Conversation
prandla
commented
Sep 24, 2026
Member
- loading of OutputOnly tasks with italy_yaml was broken, because the part that set OutputOnly was overwritten by a later if statement.
- Changed the "communication NAND interactive" check to also take outputonly into account, and made that check actually terminate the process instead of just continuing anyways.
- I also did a small cleanup (replace logging.fatal with logging.critical, since the former's docstring says "Don't use this function, use critical() instead.") and I removed some python 2 compat code.
the part that set OutputOnly was overwritten by the later if statement. i also added a check to make sure only one of the non-Batch types is specified.
logging.fatal's docstring says "Don't use this function, use critical() instead."
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1723 +/- ##
==========================================
- Coverage 56.72% 56.72% -0.01%
==========================================
Files 344 344
Lines 28310 28308 -2
==========================================
- Hits 16059 16057 -2
Misses 12251 12251
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
veluca93
approved these changes
Sep 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.