chore(tests) #20 Add missing tests - #27
Merged
Merged
Conversation
…ustom cache tasks, Adapter, bundle and DI extension Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…ends on the adapter (assertions only for ArrayAdapter) Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This was referenced Sep 30, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #20.
Completes the tests added with #22, #23 (PR #24) and #25 (PR #26), which covered the fixed behaviours:
GetTaskTest: storednullvalue, key from the process context, empty array input, input overridingadapter, unknown adapter (MissingAdapterException), options validated at initialization (missing required option, undefined option, invalid type)SetTaskTest: no output, existing item overwritten,nullvalue stored, key from the process context, unknown adapter, options validated at initializationAbstractCacheTaskTest(new): a custom task extendingAbstractCacheTaskgets its own options from the input, validated by its options resolver (as documented inindex.md)AdapterTest(new): code, and every PSR-6 method forwarded to the decorated poolCleverAgeCacheProcessExtensionTest(new): registry service, both tasks registered as non-shared services with the registry as argument and a public alias on their class (used as@<class>in process configurations)CleverAgeCacheProcessBundleTest(new):getPath()is the bundle root,build()registersRegisterAdaptersPassCoverage: 56/56 lines (44 tests).
The empty key case (placeholder
key: ''not overridden by the input) is not tested: the key validation belongs to the adapter, andArrayAdapteronly validates keys withassert(), so no exception is thrown withzend.assertions=-1(productionphp.ini, as used by the CI).Requirements
Breaking changes
None (tests only).
🤖 Generated with Claude Code