Split ExecutionFrame::Next() into a fast path and an out-of-line slow path. - #2305
Open
copybara-service[bot] wants to merge 1 commit into
Open
copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
… path. `Next()` is called once per evaluation step. It is split into a small fast path and an out-of-line `ReturnFromSubexpression()`. The fast path returns the next step in the current execution path, or `nullptr` when the top-level program finishes (which happens once per evaluation). The rare case of returning from a lazily evaluated subexpression is handled out of line. This keeps `Next()` small enough to inline into the `ExecutionFrame::Evaluate` loop without changing behavior. PiperOrigin-RevId: 989862082
copybara-service
Bot
force-pushed
the
test_989862082
branch
from
September 29, 2026 03:00
7f6e410 to
2b28b1c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split ExecutionFrame::Next() into a fast path and an out-of-line slow path.
Next()is called once per evaluation step. It is split into a small fastpath and an out-of-line
ReturnFromSubexpression(). The fast path returns thenext step in the current execution path, or
nullptrwhen the top-levelprogram finishes (which happens once per evaluation). The rare case of
returning from a lazily evaluated subexpression is handled out of line. This
keeps
Next()small enough to inline into theExecutionFrame::Evaluateloopwithout changing behavior.