Add a same-kind primitive fast path to IterativeEqualityStep. - #2304
Open
copybara-service[bot] wants to merge 1 commit into
Open
copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
- When attribute tracking is disabled and both operands have the same kind (string, int, uint, bool), `IterativeEqualityStep::Evaluate` compares them inline instead of dispatching through the generic `ValueEqual` path. Note: the upstream suite improves the equality-heavy policy benchmarks by 4-6% (BM_PolicySymbolic*); benchmarks whose INSTRUCTIONS/op is unchanged vary by +/-4% from code layout. Geomean -1.4%. PiperOrigin-RevId: 989798955
copybara-service
Bot
force-pushed
the
test_989798955
branch
from
September 29, 2026 01:22
c727045 to
6e5c84b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a same-kind primitive fast path to IterativeEqualityStep.
(string, int, uint, bool),
IterativeEqualityStep::Evaluatecompares theminline instead of dispatching through the generic
ValueEqualpath.Note: the upstream suite improves the equality-heavy policy benchmarks by
4-6% (BM_PolicySymbolic*); benchmarks whose INSTRUCTIONS/op is unchanged
vary by +/-4% from code layout. Geomean -1.4%.