Repository navigation
Fix PHP 8.6 deprecation and PHPUnit 13 assertions - #19639
Merged
Merged
Conversation
dereuromark
approved these changes
Sep 30, 2026
Spriz
changed the title
Spriz
marked this pull request as draft
September 30, 2026 14:06
Contributor
Author
|
marking as draft until CI is green |
Contributor
Author
|
Assuming last one goes green again :) sorry about that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the return out of
finallyfor PHP 8.6 and replace closure equality assertions for PHPUnit 13.The PostgreSQL segfault is fixed upstream in php/php-src#23922.
Validated: PHP 8.6 database suites, affected PHPUnit 13 tests, PHPStan and PHPCS.
🤖 Credit to gpt-6-sol ✌️