No color codes in the CLI's own output when it is piped - #58
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the output of
brefis piped or redirected (bref command ... | cat,> file.log, CI), the CLI's own lines (the spinner/progress lines and the verbose logs it shows by default in non-interactive environments) still contained ANSI color codes.The cause:
Stylesbuilds colors as raw escape codes ("\e[31m{$text}\e[39m"), not Symfony formatter tags, and Symfony only strips its own tags when the output is not decorated.IOand the spinner now strip these codes when the output is not decorated, using Symfony's decoration detection (pipes,NO_COLOR,FORCE_COLOR). In a terminal, the output is byte-for-byte identical.Since everything goes through
IO, a pipedbref commandalso drops the color codes contained in the command's own output. That's consistent with #57, which only asks Bref Cloud for colors when the output is a terminal.Tested with new
IOTest/StylesTesttests (spinner, verbose, warning, error, decorated and not), and by comparing the raw bytes of a piped run before/after (cat -v): no escape codes left when piped, identical output when decorated.