Release 4.8.4 - #960
Merged
Merged
Release 4.8.4#960
Conversation
The conn checks itself in with a cast sent after it answers the caller, so reading pool stats right after request/5 raced it on slower runners.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bump to 4.8.4 and date the NEWS entry: #959 (shared HTTP/2 close, #945 connect_timeout). Also makes h1_request_releases (from #957) wait for the pool checkin: the conn casts it after answering the caller, and the test raced it on the ARM64 runner.