Run target TLS over a TLS proxy connection - #956
Merged
Merged
Conversation
With {proxy_transport, ssl} and an HTTPS target, ssl:connect/3 ran the
target handshake over the proxy sslsocket with gen_tcp calls and failed.
Pass cb_info so it uses the ssl API of the proxy socket.
CI showed the target socket handing back lists through cb_info, which
the HTTP parser rejects. Set {mode, binary} explicitly. The test servers
now accept and handle each connection in one process.
benoitc
force-pushed
the
fix/https-proxy-https-target
branch
from
September 26, 2026 20:13
fea55b5 to
ec99836
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An HTTPS request through a CONNECT proxy reached over TLS (
{proxy_transport, ssl}) failed.ssl:connect/3ran the target handshake over the proxysslsocketwithgen_tcpcalls.hackney_http_connectnow passes{cb_info, {ssl, ssl, ssl_closed, ssl_error, ssl_passive}}in that case.New
hackney_https_proxy_testsruns a local TLS CONNECT proxy and TLS target. It covers a plain request and aset_ownerhandover, which checks that both TLS layers survive the opener exiting. Both tests fail on master.