Repository navigation
fix: missing standard includes (macOS build) - #5
Open
behnamasadi wants to merge 2 commits into
Open
behnamasadi wants to merge 2 commits into
behnamasadi wants to merge 2 commits into
Conversation
… used Found by building every target against LLVM 21 libc++ with _LIBCPP_REMOVE_TRANSITIVE_INCLUDES, which builds clean with this change. Apple's headers do not pull these in, so macOS failed. Claude-Session: https://claude.ai/code/session_01KikZtcmggL3YKN9MHjMaV2
_SC_LEVEL1_DCACHE_LINESIZE is a glibc extension; macOS exposes the value as the hw.cachelinesize sysctl. Claude-Session: https://claude.ai/code/session_01KikZtcmggL3YKN9MHjMaV2
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
macOS on master fails on std::ref without ; system_call.cpp uses system without . Building every target against LLVM 21 libc++ with _LIBCPP_REMOVE_TRANSITIVE_INCLUDES (no transitive includes) finds exactly these two; with this change that strict build is clean.
https://claude.ai/code/session_01KikZtcmggL3YKN9MHjMaV2