use Locale.ENGLISH for address folding in SignedMailValidator - #2485
Open
rootvector2 wants to merge 1 commit into
Open
rootvector2 wants to merge 1 commit into
rootvector2 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SignedMailValidatorfolds both sides of the comparison that ties a signature to the sender the message claims, the certificate's email addresses ingetEmailAddressesand theFromaddresses inhasAnyFromAddress, withLocale.getDefault()captured in a static field at class load, so on a Turkish or Azerbaijani JVMIlower cases to the dotlessıand a legitimately signed message is reported asemailFromCertMismatchwhile a certificate whoseemailAddressattribute carriesU+0130(the attribute is read throughASN1String, not restricted toIA5String) folds onto a different mailbox and satisfies the check for it; found sweeping every module'ssrc/mainfor case conversion used in a security comparison, which turned up this as the only default-locale one, the JSSEHostnameUtil,BCSNIHostNameandDisabledAlgorithmConstraintsall fixingLocale.ENGLISHand the EST hostname authorizer using the locale-independentStrings.toLowerCase.AI tooling was used to help prepare this change.