Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feat/named-child-runs #1151 +/- ##
=========================================================
+ Coverage 93.17% 93.20% +0.03%
=========================================================
Files 54 54
Lines 3690 3723 +33
=========================================================
+ Hits 3438 3470 +32
- Misses 252 253 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
vdusek
force-pushed
the
feat/child-runs-api
branch
from
October 6, 2026 13:20
08fe7c0 to
f93b3d9
Compare
vdusek
marked this pull request as ready for review
October 7, 2026 06:10
Contributor
Author
|
TODO for
✍️ Drafted by Claude Code |
Mantisus
reviewed
Oct 7, 2026
Comment on lines
+1233
to
+1238
| async def child_runs(self) -> dict[str, ChildRunInfo]: | ||
| """Get the named child runs of this Actor run, with their current state. | ||
|
|
||
| Every run started by `Actor.start`, `Actor.call` or `Actor.call_task` with a `run_name` is included, even one | ||
| started before a migration or resurrection of this Actor run. Runs started without a `run_name` are not | ||
| tracked. Each run is fetched from the API when this method is called, so the result is a snapshot. |
Collaborator
There was a problem hiding this comment.
Actor.start, Actor.call and Actor.call_task accept a token, but child_runs() fetches every run with the default client. Is a run started with a different token supposed to be supported here?
# Conflicts: # src/apify/_child_runs.py # tests/unit/actor/test_actor_child_runs.py
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #1149. Review and merge that one first.
Actor.child_runs()returns the named child runs of the current Actor run, keyed by name. EachChildRunInfohas therun_id, the run as the API returns it at call time, andhistory: the earlier runs under that name that failed or went missing and were replaced, asChildRunSnapshotentries.runisNonewhen the platform no longer has the run or the fetch failed. A failed fetch also logs a warning. Runs started without arun_namearen't tracked, so they aren't listed.Every call fetches the runs again, at most 10 at a time. Nothing is cached, so the result is a snapshot. A run started with a custom
tokenis fetched with that token. After a migration the token is gone and the default client is used. The issue leaves a status callback out of scope, so there isn't one. A caller who wants progress reporting can pollchild_runs().Docs are in #1160.
Closes: #1129
✍️ Drafted by Claude Code