Skip to content

feat: add max_total_charge_usd to task start() and call() - #1097

Merged
vdusek merged 2 commits into
masterfrom
feat/task-max-total-charge-usd
Oct 7, 2026
Merged

vdusek merged 2 commits into
masterfrom
feat/task-max-total-charge-usd

Conversation

@vdusek

@vdusek vdusek commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

TaskClient.start() and call(), sync and async, now accept max_total_charge_usd and send it as the maxTotalChargeUsd query parameter, matching ActorClient and the JS client's task.start().

The SDK needs this for apify/apify-sdk-python#1155 so that named task child runs can share the parent's charge budget.

Closes: #1096

✍️ Drafted by Claude Code

@vdusek vdusek added the t-tooling Issues with this label are in the ownership of the tooling team. label Oct 7, 2026
@vdusek vdusek self-assigned this Oct 7, 2026
@codecov

codecov Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.35%. Comparing base (3dd8ca5) to head (ef817a1).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1097   +/-   ##
=======================================
  Coverage   95.35%   95.35%           
=======================================
  Files          61       61           
  Lines        5808     5808           
=======================================
  Hits         5538     5538           
  Misses        270      270           
Flag Coverage Δ
integration 90.92% <ø> (-0.09%) ⬇️
unit 88.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vdusek
vdusek marked this pull request as ready for review October 7, 2026 09:22
@apify-service-account apify-service-account added the tested Temporary label used only programatically for some analytics. label Oct 7, 2026
@vdusek
vdusek requested a review from Mantisus October 7, 2026 12:29

@Mantisus Mantisus left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@apify-approval-mirror apify-approval-mirror Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mirroring approval from @Mantisus.

@vdusek
vdusek merged commit 966d3d6 into master Oct 7, 2026
32 checks passed
@vdusek
vdusek deleted the feat/task-max-total-charge-usd branch October 7, 2026 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-tooling Issues with this label are in the ownership of the tooling team. tested Temporary label used only programatically for some analytics.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add max_total_charge_usd to task start() and call()

3 participants