[core] Honor external data paths across table writers - #981
Merged
Merged
Conversation
leaves12138
approved these changes
Sep 28, 2026
leaves12138
left a comment
There was a problem hiding this comment.
Reviewed b63e4d99290eb781e308840874124aecdd9ef72c together with apache/paimon#10301.
Checked the per-bucket path-provider lifecycle against Java, one-time destination selection, persisted external paths, data/changelog/Blob sharing, sidecar placement, update destinations, abort cleanup, and close-failure ownership. No blocking code-review findings; no Rust implementation changes were needed.
Validation:
- Core library: 3,413 tests passed, 6 ignored.
external_data_write_test,data_file_directory_test,table_update_paths_test, andtable_update_test: 40 tests passed.- Built the Python native extension from this exact Rust revision and ran the paired Python revision with all five native execution flags: 1,836 passed, 3 skipped, 155 subtests passed (Python 3.10 / PyArrow 18.1.0).
cargo fmt --all -- --checkpassed.- All 14 GitHub checks, including Windows/macOS/Linux units, passed for this commit.
The companion Python PR remains dependent on this change and should rerun Native CI against upstream main after this PR merges. LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Follow up on #974 to honor
data-file.external-pathswhen creating data files. Rust could resolve existing external files and place external deletion vectors, but its table writers still created data files under the table directory. This also kept PyPaimon's external-path tables on the Python writer.Brief change log
external_path, and place index sidecars beside that destination.Tests
31 focused Rust tests passed:
external_data_write_test(5 tests, including the writer/strategy matrix)data_file_directory_test(7 tests)table_update_paths_test(7 tests)table::external_path::tests(8 tests)table::data_file_writer::tests(3 tests)table::dedicated_format_file_writer::tests(1 failure-injection test)Also passed:
cargo fmt --all --checkcargo clippy --locked --all-targets --workspace --features fulltext,vortex -- -D warningsAPI and Format
No public API or storage-format change. File placement uses the existing Java-compatible options and
DataFileMeta.external_pathfield.Documentation
The companion PyPaimon PR apache/paimon#10301 enables and documents native external writes. PyPaimon's Blob writer fallback is preserved because its remaining native Blob input/metadata behavior needs separate work.