fix(arrow): read CSV boolean columns like Java's CsvParser - #980
Open
jackylee-ch wants to merge 1 commit into
Open
jackylee-ch wants to merge 1 commit into
jackylee-ch wants to merge 1 commit into
Conversation
CSV boolean columns were cast with `arrow_cast`, whose string->boolean mapping reads "1", "yes", "t", "on" and "y" as true and unrecognized tokens such as "2" or "invalid" as null. Java `CsvParser` reads BOOLEAN via `Boolean.parseBoolean`: only "true" (case-insensitive) is true, every other non-null token is false, and it never yields null. Reading the same CSV format-table file through Rust therefore flipped boolean values (and produced nulls) relative to Java, changing filter and query results across engines. Parse CSV boolean fields with the same rule so a format table reads identically across engines. Null fields stay null.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CSV boolean columns were cast with
arrow_cast, whose string->boolean mapping reads1,yes,t,onandyas true and unrecognized tokens such as2orinvalidas null. JavaCsvParserreads BOOLEAN viaBoolean.parseBoolean: onlytrue(case-insensitive) is true, every other non-null token is false, and it never yields null.Reading the same CSV format-table file through Rust therefore flipped boolean values —
1/yes/tbecame true instead of false — and turned tokens likeinvalidinto null, soWHERE flag = truereturned different rows than Java, Spark or Flink over the same file.Parse CSV boolean fields with the same rule so a format table reads identically across engines; null fields stay null. Verified by a unit test that fails under the old
arrow_castbehavior.