Skip to content

Netris: Improvements and fixes to the Netris plugin - #13591

Open
Pearl1594 wants to merge 15 commits into
4.22from
netris-improvements
Open

Netris: Improvements and fixes to the Netris plugin#13591
Pearl1594 wants to merge 15 commits into
4.22from
netris-improvements

Merge branch '4.22' into netris-improvements

c5ee6d1
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Sep 30, 2026 in 8m 35s

Quality Gate failed

Failed conditions
4.3% Coverage on New Code (required ≥ 40%)

See analysis details on SonarQube Cloud

Annotations

Check warning on line 3913 in server/src/main/java/com/cloud/network/vpc/VpcManagerImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Merge this if statement with the enclosing one. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaCmxdSMvdOsGv8pnnSt&open=AaCmxdSMvdOsGv8pnnSt&pullRequest=13591

Check warning on line 138 in server/src/main/java/com/cloud/network/vpn/RemoteAccessVpnManagerImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this field injection and use constructor injection instead. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaCmxdS-vdOsGv8pnnSw&open=AaCmxdS-vdOsGv8pnnSw&pullRequest=13591

Check warning on line 462 in plugins/network-elements/netris/src/main/java/org/apache/cloudstack/service/NetrisApiClientImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Extract this nested try block into a separate method. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaCmxdIZvdOsGv8pnnSi&open=AaCmxdIZvdOsGv8pnnSi&pullRequest=13591

Check warning on line 139 in server/src/main/java/com/cloud/network/vpn/RemoteAccessVpnManagerImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this field "_vpcOfferingServiceMapDao" to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaCmxdS-vdOsGv8pnnSv&open=AaCmxdS-vdOsGv8pnnSv&pullRequest=13591

Check warning on line 115 in api/src/main/java/com/cloud/network/netris/NetrisService.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Method has 9 parameters, which is greater than 7 authorized. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaCmxdHkvdOsGv8pnnSS&open=AaCmxdHkvdOsGv8pnnSS&pullRequest=13591

Check failure on line 238 in api/src/main/java/org/apache/cloudstack/api/command/admin/vpc/CreateVPCOfferingCmd.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "service" 3 times. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaCmxdB3vdOsGv8pnnSP&open=AaCmxdB3vdOsGv8pnnSP&pullRequest=13591

Check warning on line 284 in api/src/main/java/org/apache/cloudstack/api/command/admin/vpc/CreateVPCOfferingCmd.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Change "Object" to the type handled by the Collection. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaCmxdB3vdOsGv8pnnSQ&open=AaCmxdB3vdOsGv8pnnSQ&pullRequest=13591

Check warning on line 99 in api/src/main/java/com/cloud/network/netris/NetrisService.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Method has 11 parameters, which is greater than 7 authorized. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaCmxdHkvdOsGv8pnnSR&open=AaCmxdHkvdOsGv8pnnSR&pullRequest=13591

Check warning on line 532 in server/src/main/java/com/cloud/network/guru/GuestNetworkGuru.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Format specifiers should be used instead of string concatenation. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaCmxdQNvdOsGv8pnnSs&open=AaCmxdQNvdOsGv8pnnSs&pullRequest=13591

Check warning on line 547 in plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetes/cluster/actionworkers/KubernetesClusterActionWorker.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the declaration of thrown exception 'com.cloud.exception.ResourceUnavailableException', as it cannot be thrown from method's body. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaCmxdMcvdOsGv8pnnSq&open=AaCmxdMcvdOsGv8pnnSq&pullRequest=13591

Check warning on line 610 in plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetes/cluster/actionworkers/KubernetesClusterActionWorker.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Invoke method(s) only conditionally. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaCmxdMcvdOsGv8pnnSp&open=AaCmxdMcvdOsGv8pnnSp&pullRequest=13591

Check failure on line 74 in plugins/network-elements/netris/src/main/java/org/apache/cloudstack/service/NetrisPublicNetworkGuru.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 18 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaCmxdIGvdOsGv8pnnSh&open=AaCmxdIGvdOsGv8pnnSh&pullRequest=13591

Check warning on line 1433 in server/src/main/java/com/cloud/network/IpAddressManagerImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Return an empty collection instead of null. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaCmxdVWvdOsGv8pnnSx&open=AaCmxdVWvdOsGv8pnnSx&pullRequest=13591

Check warning on line 3921 in server/src/main/java/com/cloud/network/vpc/VpcManagerImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Merge this if statement with the enclosing one. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaCmxdSMvdOsGv8pnnSu&open=AaCmxdSMvdOsGv8pnnSu&pullRequest=13591

Check warning on line 131 in api/src/main/java/com/cloud/network/netris/NetrisService.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Method has 9 parameters, which is greater than 7 authorized. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaCmxdHkvdOsGv8pnnST&open=AaCmxdHkvdOsGv8pnnST&pullRequest=13591

Check warning on line 562 in plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetes/cluster/actionworkers/KubernetesClusterActionWorker.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Invoke method(s) only conditionally. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaCmxdMcvdOsGv8pnnSo&open=AaCmxdMcvdOsGv8pnnSo&pullRequest=13591

Check failure on line 1471 in plugins/network-elements/netris/src/main/java/org/apache/cloudstack/service/NetrisApiClientImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 16 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaCmxdIZvdOsGv8pnnSk&open=AaCmxdIZvdOsGv8pnnSk&pullRequest=13591

Check warning on line 556 in plugins/network-elements/netris/src/main/java/org/apache/cloudstack/service/NetrisServiceImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Move the conditional expression inside this operation. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaCmxdI1vdOsGv8pnnSn&open=AaCmxdI1vdOsGv8pnnSn&pullRequest=13591

Check failure on line 366 in plugins/network-elements/netris/src/main/java/org/apache/cloudstack/service/NetrisElement.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to not always return the same value. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaCmxdImvdOsGv8pnnSl&open=AaCmxdImvdOsGv8pnnSl&pullRequest=13591

Check failure on line 1220 in plugins/network-elements/netris/src/main/java/org/apache/cloudstack/service/NetrisApiClientImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 40 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaCmxdIZvdOsGv8pnnSj&open=AaCmxdIZvdOsGv8pnnSj&pullRequest=13591

Check warning on line 383 in plugins/network-elements/netris/src/main/java/org/apache/cloudstack/service/NetrisServiceImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Move the array designators [] to the type. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaCmxdI1vdOsGv8pnnSm&open=AaCmxdI1vdOsGv8pnnSm&pullRequest=13591

Check warning on line 932 in server/src/main/java/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Format specifiers should be used instead of string concatenation. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaCmxdPavdOsGv8pnnSr&open=AaCmxdPavdOsGv8pnnSr&pullRequest=13591
View more details on SonarQubeCloud