Conversation
Abacn
force-pushed
the
stale-bq-dataset
branch
from
September 25, 2026 18:33
8abe13b to
500e9b7
Compare
Abacn
force-pushed
the
stale-bq-dataset
branch
from
September 25, 2026 18:36
500e9b7 to
7522449
Compare
* Fix dataset leak in `BigqueryClient.deleteDataset` when a test dataset contains >50 tables (e.g. `StorageApiSinkCreateIfNeededIT` due to response page truncation * Use a unified prefix for integration tests to avoid temp dataset
Abacn
force-pushed
the
stale-bq-dataset
branch
from
September 25, 2026 19:43
7522449 to
acbbe46
Compare
Abacn
marked this pull request as ready for review
September 25, 2026 19:44
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #40286 +/- ##
============================================
- Coverage 56.14% 55.12% -1.03%
+ Complexity 2288 1722 -566
============================================
Files 1121 1076 -45
Lines 177152 172005 -5147
Branches 1488 1262 -226
============================================
- Hits 99467 94822 -4645
+ Misses 75161 74907 -254
+ Partials 2524 2276 -248
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix dataset leak in
BigqueryClient.deleteDatasetwhen a test dataset contains >50 tables (e.g.StorageApiSinkCreateIfNeededITdue to response page truncationUse a unified prefix for integration tests to avoid temp dataset
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.