Skip to content

Fix many flaky tests - #40280

Open
reuvenlax wants to merge 6 commits into
apache:masterfrom
reuvenlax:fix_flaky_tests
Open

reuvenlax wants to merge 6 commits into
apache:masterfrom
reuvenlax:fix_flaky_tests

Conversation

@reuvenlax

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions

Copy link
Copy Markdown
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@jrmccluskey

Copy link
Copy Markdown
Contributor

I would suggest splitting these out per-language to make iteration and review a little easier.

@codecov

codecov Bot commented Sep 25, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 4.76190% with 20 lines in your changes missing coverage. Please review.
✅ Project coverage is 58.86%. Comparing base (e3b3e7c) to head (b42a676).
⚠️ Report is 18 commits behind head on master.

Files with missing lines Patch % Lines
sdks/python/apache_beam/yaml/integration_tests.py 0.00% 11 Missing ⚠️
.../apache_beam/yaml/test_utils/datadog_test_utils.py 0.00% 5 Missing ⚠️
sdks/python/apache_beam/io/gcp/bigtableio.py 20.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #40280      +/-   ##
============================================
- Coverage     58.86%   58.86%   -0.01%     
  Complexity    15416    15416              
============================================
  Files          2793     2793              
  Lines        279197   279217      +20     
  Branches      12399    12394       -5     
============================================
+ Hits         164358   164368      +10     
- Misses       108388   108401      +13     
+ Partials       6451     6448       -3     
Flag Coverage Δ
python 79.82% <4.76%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

Copy link
Copy Markdown
Contributor

Assigning reviewers:

R: @damccorm for label python.
R: @ahmedabu98 for label java.
R: @lostluck for label go.
R: @derrickaw for label yaml.
R: @igorbernstein2 for label bigtable.

This pull request likely touches a core component ("core" label). Please review with scrutiny.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@lostluck lostluck left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the PrismRunner java changes and the worker.go changes.

Comment on lines +330 to +331
# MongoDbContainer's entrypoint restarts mongod after init scripts; wait
# until the server is stably accepting connections and responds to ping.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# MongoDbContainer's entrypoint restarts mongod after init scripts; wait
# until the server is stably accepting connections and responds to ping.
# MongoDbContainer's entrypoint restarts mongodb after init scripts; wait
# until the server is stable, accepting connections, and responds to ping.

@github-actions github-actions Bot added the mqtt label Sep 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants