Repository navigation
Conversation
Reranko05
changed the title
Reranko05
force-pushed
the
example-doc
branch
from
September 19, 2026 20:23
3842058 to
9813fc2
Compare
Reranko05
changed the title
Collaborator
Author
|
Will mark this PR |
pitrou
reviewed
Oct 8, 2026
| // * arrow::TableBatchReader and Arrow iterators for converting Arrow tables back | ||
| // into row-based JSON data | ||
|
|
||
| namespace arrow { |
Member
There was a problem hiding this comment.
Example code shouldn't be in the arrow namespace because it showcases how third-party code using Arrow C++ could look like.
Collaborator
Author
There was a problem hiding this comment.
Ah, okay. I got it.
pitrou
reviewed
Oct 8, 2026
Comment on lines
+41
to
+42
| // * arrow::internal::JsonWriter for writing JSON values | ||
| // * arrow::internal::ParseJsonObject and related helpers for parsing JSON |
Member
There was a problem hiding this comment.
Examples should not use any internal Arrow APIs.
Collaborator
Author
There was a problem hiding this comment.
Okay, understood.
github-actions
Bot
added
awaiting committer review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
This PR continues the simdjson migration by replacing RapidJSON usage in the C++ row converter example with simdjson and Arrow's existing
JsonWriter.Changes
JsonWriter.arrow::simdjson.Was AI used for this PR?
In accordance to the AI generation guidelines, please disclose below whether and how AI was used in this PR.
PR code and description written by:
Reviewed before submission by: