Repository navigation
Mark agtype_string_match_starts_with/_ends_with IMMUTABLE - #2579
Open
mmustafasenoglu wants to merge 1 commit into
Open
mmustafasenoglu wants to merge 1 commit into
mmustafasenoglu wants to merge 1 commit into
Conversation
Same inputs always produce the same output with no catalog lookups or session state, matching agtype_string_match_contains which is already IMMUTABLE. Unblocks user-built expression indexes on STARTS WITH / ENDS WITH predicates. Fixes apache#2576
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2576
starts_with and ends_with are pure string comparisons over their inputs, same as contains which is already IMMUTABLE, so there is no reason for them to stay STABLE. This unblocks user-built expression indexes on STARTS WITH / ENDS WITH predicates (Postgres rejects STABLE functions in index expressions).
Changes: