docs: clarify test builders include and exclude schema descriptions - #34204
Merged
Merged
Conversation
The schema descriptions for the "include" and "exclude" options in the test builders previously stated that glob patterns were relative to the project root. In practice, test discovery resolves patterns relative to the project source root. This updates the descriptions to accurately reflect that patterns are relative to the project source root.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the schema descriptions for the Karma and unit-test builders to clarify that the include and exclude glob patterns are relative to the project source root rather than the project root. The feedback identifies minor grammatical issues in the updated descriptions and provides suggestions to improve readability.
alan-agius4
approved these changes
Sep 29, 2026
alan-agius4
left a comment
alan-agius4
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, once the descriptions are updated.
1 task
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The schema descriptions for the "include" and "exclude" options in the test builders previously stated that glob patterns were relative to the project root. In practice, test discovery resolves patterns relative to the project source root. This updates the descriptions to accurately reflect that patterns are relative to the project source root.