perf(@angular/build): cache transformed configuration in TypeScript compilation - #34192
Open
alan-agius4 wants to merge 2 commits into
Open
alan-agius4 wants to merge 2 commits into
alan-agius4 wants to merge 2 commits into
Conversation
…ompilation When `rootFiles` are explicitly provided (such as in library builds), avoid re-reading and re-parsing `tsconfig.json` and traversing the project directory structure on every watch rebuild. Cache the `TransformedConfiguration` and invalidate it only when a `.json` configuration file changes.
angular-robot
Bot
added
area: performance
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a caching mechanism for the TypeScript configuration in the Angular build process to improve performance during watch mode rebuilds. The reviewer suggests enhancing this cache by tracking the 'rootFiles' to ensure the cache is properly invalidated when the set of root files changes, preventing potential compilation errors or stale configurations. All review comments are actionable and provide necessary improvements to the implementation.
…cript compilation
alan-agius4
added
target: patch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
rootFilesare explicitly provided (e.g. in library builds), re-parsingtsconfig.jsonand traversing the project directory structure viareadConfigurationon every incremental watch rebuild is redundant and adds measurable overhead (~200-350ms on large libraries).This change caches the
TransformedConfigurationinTypeScriptCompilationwhen explicitrootFilesare provided and invalidates the cache only when a.jsonconfiguration file changes.