Skip to content

fix(windows): link against synchronization - #13

Merged
torque merged 3 commits into
allyourcodebase:masterfrom
clason:fix/synchronization
Oct 2, 2026
Merged

torque merged 3 commits into
allyourcodebase:masterfrom
clason:fix/synchronization

Conversation

@clason

@clason clason commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

Disclaimer: I know virtually nothing about building on Windows. @torque

@clason
clason force-pushed the fix/synchronization branch from 20a5db9 to 9f3c6a3 Compare October 1, 2026 13:34
@clason

clason commented Oct 1, 2026

Copy link
Copy Markdown
Contributor Author

Downstream (Neovim) build passes with this change: https://github.com/neovim/neovim/actions/runs/36870158951/job/110396151088?pr=42072

@torque

torque commented Oct 2, 2026

Copy link
Copy Markdown
Collaborator

Hmm. Interesting that this library is just called synchronization in the upstream build system. Fiddling around with this, it seems to be the difference between building with MSVC vs mingw for windows. The MSVC debug builds were already broken since ucrtbased is a mingw library, but playing around with this locally it seems straightforward to work with either ABI. No clue if anyone cares about the MSVC ABI on windows for this build system, but we might as well support it.

@torque
torque merged commit 88bb15e into allyourcodebase:master Oct 2, 2026
18 checks passed
@clason
clason deleted the fix/synchronization branch October 2, 2026 07:18
@clason

clason commented Oct 2, 2026

Copy link
Copy Markdown
Contributor Author

Yes, that threw me as well -- it really is different in CMake and Zig. I tried both names in both systems, and that is the only combination that worked. Let's see if this works for downstream builds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants