You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hmm. Interesting that this library is just called synchronization in the upstream build system. Fiddling around with this, it seems to be the difference between building with MSVC vs mingw for windows. The MSVC debug builds were already broken since ucrtbased is a mingw library, but playing around with this locally it seems straightforward to work with either ABI. No clue if anyone cares about the MSVC ABI on windows for this build system, but we might as well support it.
Yes, that threw me as well -- it really is different in CMake and Zig. I tried both names in both systems, and that is the only combination that worked. Let's see if this works for downstream builds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disclaimer: I know virtually nothing about building on Windows. @torque