Require GC for waitqueues - #9177
Merged
Merged
Conversation
stevenfontanella
added this pull request to stack #9178
October 1, 2026 15:16
stevenfontanella
marked this pull request as ready for review
October 1, 2026 15:23
stevenfontanella
requested review from
a team,
aheejin and
kripken
and removed request for
a team and
aheejin
October 1, 2026 15:23
kripken
approved these changes
Oct 1, 2026
stevenfontanella
removed this pull request from stack #9178
October 1, 2026 18:07
stevenfontanella
enabled auto-merge (squash)
October 1, 2026 18:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Waitqueue instructions only make sense when GC is enabled. e.g.
struct.waittakes a struct reference which requires GC anyway, and waitqueues live on the GC heap. This is also needed for #9172 to pass this check.Part of #8315.