ty: un-ignore parameter-already-assigned (1 file, 1 spot) - #15463
Open
HasanGenis wants to merge 1 commit into
Open
HasanGenis wants to merge 1 commit into
HasanGenis wants to merge 1 commit into
Conversation
plt.axes(projection="3d") is typed to return the base 2D Axes, so ax.scatter's 3rd positional arg (meant as zs) was resolving against 2D Axes.scatter's `s` parameter and colliding with the explicit s=100 kwarg. Cast ax to Axes3D so ty resolves the correct (xs, ys, zs, ...) overload instead. Part of TheAlgorithms#15187
algorithms-keeper
Bot
added
awaiting reviews
|
So much difficult to understand 😕 |
cclauss
requested changes
Sep 29, 2026
| @@ -157,7 +159,10 @@ def plot_heterogeneity(heterogeneity, k) -> None: | |||
|
|
|||
|
|
|||
| def plot_kmeans(data, centroids, cluster_assignment) -> None: | |||
Member
There was a problem hiding this comment.
We need type hints for data, centroids, and cluster_assignment
algorithms-keeper
Bot
added
awaiting changes
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
plt.axes(projection="3d")is typed to return the base 2DAxes, soax.scatter's 3rd positional argument (meant aszs) was resolving against 2DAxes.scatter'ssparameter and colliding with the explicits=100kwarg — this was the repo's onlyparameter-already-assigneddiagnostic. CastaxtoAxes3Dsotyresolves the correct(xs, ys, zs, ...)overload instead (no runtime behavior change), and un-ignore the rule inpyproject.tomlnow that its diagnostic count is zero repo-wide.Part of #15187 (supersedes #15460, which I accidentally left with an unmarked checklist)
Describe your change
Checklist