chore(eslint-plugin-query): move '@typescript-eslint/rule-tester' to the pnpm catalog by sukvvon · Pull Request #11822 · TanStack/query

sukvvon · 2026-10-03T15:19:43Z

🎯 Changes

Moves @typescript-eslint/rule-tester (a devDependency of eslint-plugin-query) to the pnpm catalog, next to @typescript-eslint/parser:

catalog:
  '@typescript-eslint/parser': ^8.71.0
  '@typescript-eslint/rule-tester': ^8.71.0

typescript-eslint packages are released together under the same version, so keeping both in the catalog lets them be updated in one place. The resolved version stays 8.71.0.

✅ Checklist

I have followed the steps in the Contributing guide.
I have tested code changes locally with pnpm run test:pr, or these tests do not apply to this pull request.
I have followed the AI contribution policy and fully understand the code in this pull request, including any code generated with AI assistance.

🚀 Release Impact

This change affects published code, and I have generated a changeset.
This change is docs/CI/dev-only (no release).

Summary by CodeRabbit

Chores
- Updated development tooling configuration to use the workspace-managed version of the rule-testing tool, keeping its version consistent with the workspace catalog.
- This configuration change does not affect application behavior or add user-facing features.

…the pnpm catalog

changeset-bot · 2026-10-03T15:19:49Z

⚠️ No Changeset found

Latest commit: 26d3a23

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

nx-cloud · 2026-10-03T15:20:06Z

View your CI Pipeline Execution ↗ for commit 26d3a23

Command	Status	Duration	Result
`nx affected --targets=test:sherif,test:knip,tes...`	✅ Succeeded	3m 38s	View ↗
`nx run-many --target=build --exclude=examples/*...`	✅ Succeeded	37s	View ↗

☁️ Nx Cloud last updated this comment at 2026-10-03 15:24:24 UTC

github-actions · 2026-10-03T15:20:43Z

🚀 Changeset Version Preview

No changeset entries found. Merging this PR will not cause a version bump for any packages.

coderabbitai · 2026-10-03T15:21:41Z

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: TanStack/query/.coderabbit.yaml
Review profile: CHILL
Plan: Advanced
Run ID: 48e178f8-33f8-42f2-bdd5-829d87aa97e5

📥 Commits

Reviewing files that changed from the base of the PR and between 7726974 and 26d3a23.

⛔ Files ignored due to path filters (1)

pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml

📒 Files selected for processing (2)

packages/eslint-plugin-query/package.json
pnpm-workspace.yaml

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review.

📝 Walkthrough

Walkthrough

The workspace catalog now defines the @typescript-eslint/rule-tester version. The ESLint plugin package uses the catalog entry instead of a fixed version range.

Changes

Dependency catalog update

Layer / File(s)	Summary
Define and reference the catalog version `pnpm-workspace.yaml`, `packages/eslint-plugin-query/package.json`	The workspace catalog adds `@typescript-eslint/rule-tester` at `^8.71.0`. The package manifest uses the catalog reference.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Suggested reviewers: lachlancollins

Merge Risk: ⚪ Minimal · up to 26d3a

The development dependency remains at the same resolved version, so this change presents no material user-facing risk and is ready to merge.

Architecture Summary

Architecture risk: 🔵 Low · up to 26d3a

The change affects 2 systems.

Changed systems: packages/eslint-plugin-query, pnpm-workspace.yaml

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

observed — packages/eslint-plugin-query (library) was modified; 1 changed file maps to changed impact.
observed — pnpm-workspace.yaml (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

observed — Modified behavior in packages/eslint-plugin-query/package.json: The development dependency changes from the explicit ^8.71.0 version range to the workspace catalog: version.
observed — Modified behavior in pnpm-workspace.yaml: Adds @typescript-eslint/rule-tester to the dependency catalog with version range ^8.71.0.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely describes the main change: moving `@typescript-eslint/rule-tester` to the pnpm catalog.
Description check	✅ Passed	The description includes all required sections, explains the change and its motivation, completes the checklist, and identifies the change as dev-only with no release impact.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Commit to this branch
Create a new PR

Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

pkg-pr-new · 2026-10-03T15:21:59Z

More templates

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@11822

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@11822

@tanstack/lit-query

npm i https://pkg.pr.new/@tanstack/lit-query@11822

@tanstack/preact-query

npm i https://pkg.pr.new/@tanstack/preact-query@11822

@tanstack/preact-query-devtools

npm i https://pkg.pr.new/@tanstack/preact-query-devtools@11822

@tanstack/preact-query-persist-client

npm i https://pkg.pr.new/@tanstack/preact-query-persist-client@11822

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@11822

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@11822

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@11822

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@11822

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@11822

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@11822

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@11822

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@11822

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@11822

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@11822

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@11822

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@11822

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@11822

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@11822

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@11822

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@11822

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@11822

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@11822

commit: 26d3a23

github-actions · 2026-10-03T15:23:02Z

size-limit report 📦

Path	Size
react full	11.73 KB (0%)
react minimal	8.58 KB (0%)

chore(eslint-plugin-query): move '@typescript-eslint/rule-tester' to …

26d3a23

…the pnpm catalog

sukvvon self-assigned this Oct 3, 2026

sukvvon merged commit 79d1f22 into main Oct 3, 2026
9 checks passed

sukvvon deleted the chore/typescript-eslint-rule-tester-catalog branch October 3, 2026 15:27

Navigation Menu

Repository navigation

chore(eslint-plugin-query): move '@typescript-eslint/rule-tester' to the pnpm catalog - #11822

chore(eslint-plugin-query): move '@typescript-eslint/rule-tester' to the pnpm catalog#11822
sukvvon merged 1 commit into
mainfrom
chore/typescript-eslint-rule-tester-catalog

sukvvon commented Oct 3, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

changeset-bot Bot commented Oct 3, 2026

Uh oh!

nx-cloud Bot commented Oct 3, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Oct 3, 2026

Uh oh!

coderabbitai Bot commented Oct 3, 2026 •

edited

Loading

Walkthrough

Changes

Uh oh!

pkg-pr-new Bot commented Oct 3, 2026

Uh oh!

github-actions Bot commented Oct 3, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

sukvvon commented Oct 3, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎯 Changes

✅ Checklist

🚀 Release Impact

Summary by CodeRabbit

Uh oh!

changeset-bot Bot commented Oct 3, 2026

⚠️ No Changeset found

Uh oh!

nx-cloud Bot commented Oct 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Oct 3, 2026

🚀 Changeset Version Preview

Uh oh!

coderabbitai Bot commented Oct 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Architecture Summary

Uh oh!

pkg-pr-new Bot commented Oct 3, 2026

Uh oh!

github-actions Bot commented Oct 3, 2026

size-limit report 📦

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

sukvvon commented Oct 3, 2026 •

edited by coderabbitai Bot

Loading

nx-cloud Bot commented Oct 3, 2026 •

edited

Loading

coderabbitai Bot commented Oct 3, 2026 •

edited

Loading